HHH-19716 Set the collection owner when wrapping a collection into a persistent one #10778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beikov
approved these changes
Aug 19, 2025
yrodiere
reviewed
Aug 25, 2025
hibernate-core/src/main/java/org/hibernate/internal/StatelessSessionImpl.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/internal/StatelessSessionImpl.java
Outdated
Show resolved
Hide resolved
Comment on lines
106
to
+108
| public void onPostRemoveCollection(PostCollectionRemoveEvent event) { | ||
| assertThat( event.getAffectedOwnerOrNull() ).isNotNull(); | ||
| assertThat( event.getCollection().getOwner() ).isNotNull(); |
There was a problem hiding this comment.
We want the owner to be non-null after a remove?
There was a problem hiding this comment.
that ... idk 🤷🏻 🙂
wouldn't we want to know to what the collection belonged to before it was removed?
My thinking is that event.getAffectedOwnerOrNull() == event.getCollection().getOwner()
There was a problem hiding this comment.
If you're sure this is pre-existing behavior and we don't need to change it to fix the bug, fine by me.
marko-bekhta
force-pushed
the
fix/HHH-19716-Collection-event-listeners-may-be-missing-collection-owners-in-the-persistent-collection
branch
from
2ef4bdd to
23f9fac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-19716
It doesn't look like
wrap()is called by Reactive directly, so it seems safe to update the method, no?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.